SPIFFS and Timer intterupt will crash ESP32

JacoFourie
Posts: 13
Joined: Mon Jan 22, 2018 7:54 pm

SPIFFS and Timer intterupt will crash ESP32

Postby JacoFourie » Thu Feb 22, 2018 2:42 pm

I need to run some code every 1000 micro seconds. The timer code works on its own and the SPIFFS code works on its own. But as soon as you use a Timer with SPIFFS the ESP32 will crash and burn.

I just added a timer to the SPIFFS sample to show you it will reboot all the time.

If you comment out the TimerEnable the code will run. Here is the code.

Code: Select all

#include "FS.h"
#include "SPIFFS.h"


hw_timer_t * timer = NULL;
portMUX_TYPE timerMux = portMUX_INITIALIZER_UNLOCKED;


void listDir(fs::FS &fs, const char * dirname, uint8_t levels){
    Serial.printf("Listing directory: %s\n", dirname);

    File root = fs.open(dirname);
    if(!root){
        Serial.println("Failed to open directory");
        return;
    }
    if(!root.isDirectory()){
        Serial.println("Not a directory");
        return;
    }

    File file = root.openNextFile();
    while(file){
        if(file.isDirectory()){
            Serial.print("  DIR : ");
            Serial.println(file.name());
            if(levels){
                listDir(fs, file.name(), levels -1);
            }
        } else {
            Serial.print("  FILE: ");
            Serial.print(file.name());
            Serial.print("  SIZE: ");
            Serial.println(file.size());
        }
        file = root.openNextFile();
    }
}

void readFile(fs::FS &fs, const char * path){
    Serial.printf("Reading file: %s\n", path);

    File file = fs.open(path);
    if(!file || file.isDirectory()){
        Serial.println("Failed to open file for reading");
        return;
    }

    Serial.print("Read from file: ");
    while(file.available()){
        Serial.write(file.read());
    }
}

void writeFile(fs::FS &fs, const char * path, const char * message){
    Serial.printf("Writing file: %s\n", path);

    File file = fs.open(path, FILE_WRITE);
    if(!file){
        Serial.println("Failed to open file for writing");
        return;
    }
    if(file.print(message)){
        Serial.println("File written");
    } else {
        Serial.println("Write failed");
    }
}

void appendFile(fs::FS &fs, const char * path, const char * message){
    Serial.printf("Appending to file: %s\n", path);

    File file = fs.open(path, FILE_APPEND);
    if(!file){
        Serial.println("Failed to open file for appending");
        return;
    }
    if(file.print(message)){
        Serial.println("Message appended");
    } else {
        Serial.println("Append failed");
    }
}

void renameFile(fs::FS &fs, const char * path1, const char * path2){
    Serial.printf("Renaming file %s to %s\n", path1, path2);
    if (fs.rename(path1, path2)) {
        Serial.println("File renamed");
    } else {
        Serial.println("Rename failed");
    }
}

void deleteFile(fs::FS &fs, const char * path){
    Serial.printf("Deleting file: %s\n", path);
    if(fs.remove(path)){
        Serial.println("File deleted");
    } else {
        Serial.println("Delete failed");
    }
}

void testFileIO(fs::FS &fs, const char * path){
    File file = fs.open(path);
    static uint8_t buf[512];
    size_t len = 0;
    uint32_t start = millis();
    uint32_t end = start;
    if(file && !file.isDirectory()){
        len = file.size();
        size_t flen = len;
        start = millis();
        while(len){
            size_t toRead = len;
            if(toRead > 512){
                toRead = 512;
            }
            file.read(buf, toRead);
            len -= toRead;
        }
        end = millis() - start;
        Serial.printf("%u bytes read for %u ms\n", flen, end);
        file.close();
    } else {
        Serial.println("Failed to open file for reading");
    }


    file = fs.open(path, FILE_WRITE);
    if(!file){
        Serial.println("Failed to open file for writing");
        return;
    }

    size_t i;
    start = millis();
    for(i=0; i<2048; i++){
        file.write(buf, 512);
    }
    end = millis() - start;
    Serial.printf("%u bytes written for %u ms\n", 2048 * 512, end);
    file.close();
}

void setup(){
    Serial.begin(115200);
    if(!SPIFFS.begin()){
        Serial.println("SPIFFS Mount Failed");
        return;
    }


    timer = timerBegin(0, 80, true);
    timerAttachInterrupt(timer, &timerIsr, true);
    timerAlarmWrite(timer, 1000, true);
    //timerAlarmEnable(timer);
    
    listDir(SPIFFS, "/", 0);
    writeFile(SPIFFS, "/hello.txt", "Hello ");
    appendFile(SPIFFS, "/hello.txt", "World!\n");
    readFile(SPIFFS, "/hello.txt");
    deleteFile(SPIFFS, "/foo.txt");
    renameFile(SPIFFS, "/hello.txt", "/foo.txt");
    readFile(SPIFFS, "/foo.txt");
    testFileIO(SPIFFS, "/test.txt");
}

void loop(){

}




void timerIsr() {
  portENTER_CRITICAL(&timerMux);       
  portEXIT_CRITICAL(&timerMux);
}
And her eis the output from the Exception

Code: Select all

ecoding 8 results
0x400d0bbc: timerIsr() at C:\Users\Jaco\AppData\Local\Temp\arduino_modified_sketch_175913/SPIFFS_Test.ino line 178
0x400815f4: _xt_lowint1 at /Users/ficeto/Desktop/ESP32/ESP32/esp-idf-public/components/freertos/./xtensa_vectors.S line 1105
0x40086300: _frxt_int_enter at /Users/ficeto/Desktop/ESP32/ESP32/esp-idf-public/components/freertos/./portasm.S line 119
So can you run a Timer with SPIFFS ? Or will they not work together at all ?

JacoFourie
Posts: 13
Joined: Mon Jan 22, 2018 7:54 pm

Re: SPIFFS and Timer intterupt will crash ESP32

Postby JacoFourie » Thu Feb 22, 2018 7:33 pm

OK this is solved.

I had to add DRAM_ATTR to the interrupt and all the function called by the interrupt.
I also had to move the ISR above the setup function.

MONISHA
Posts: 1
Joined: Wed Jul 10, 2019 6:17 am

Re: SPIFFS and Timer intterupt will crash ESP32

Postby MONISHA » Wed Jul 10, 2019 6:21 am

Hi JacoFourie ,


I also facing the same issue.How u add DRAM_ATTR to the interrupt .Can u please share some example code?

Warm regards,
Monisha OM

Dinosaur
Posts: 1
Joined: Fri Oct 16, 2020 12:47 pm

Re: SPIFFS and Timer intterupt will crash ESP32

Postby Dinosaur » Fri Oct 16, 2020 1:02 pm

here is a simple example of an isr that crashed when used with Spiffs but is now fixed by adding DRAM_ATTR.
It is a 6 channel PPM generator.

void inline onTimer(void) {
DRAM_ATTR
static int laststate = 1;
static int ch = 0;
static int thstep = 1;
digitalWrite(sigPin,laststate);
portENTER_CRITICAL_ISR(&timerMux);
timerWrite(timer,0);
if (laststate == 1) {
laststate = 0;
timerAlarmWrite(timer,(gap[ch]+15),true);
ch ++;
}else{laststate = 1;

timerAlarmWrite(timer,300,true);
}
portEXIT_CRITICAL_ISR(&timerMux);
if(ch == 7) {
ch = 0;
if(mix == false){
thstep = 1;
if (vrec == 100) {
ppm[ChMapDef[0]] = (1200+thtrim);
}
}
if(mix==true){
thstep = 2;
if (vrec == 23) {
ppm[ChMapDef[0]] = (700+thtrim);
}

}
}
}

I hope that helps.

Who is online

Users browsing this forum: PepeTheGreat and 52 guests